Skip to content

Commit b53831a

Browse files
committed
test: move NAPI_EXPERIMENTAL definition to cmake file (nodejs/node#51254)
1 parent 526f6c4 commit b53831a

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

packages/test/CMakeLists.txt

+2
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,7 @@ add_test("tsfn2_st" "./tsfn2/binding.c" OFF)
253253

254254
if((NOT IS_WASM) OR IS_EMSCRIPTEN OR IS_WASI_THREADS)
255255
add_test("string_mt" "./string/binding.c;./string/test_null.c" ON)
256+
target_compile_definitions("string_mt" PRIVATE "NAPI_EXPERIMENTAL")
256257
add_test("pool" "./pool/binding.c" ON)
257258
add_test("tsfn" "./tsfn/binding.c" ON)
258259
add_test("async_cleanup_hook" "./async_cleanup_hook/binding.c" ON)
@@ -267,6 +268,7 @@ add_test("fnfac" "./fnfac/binding.c" OFF)
267268
add_test("general" "./general/binding.c" OFF)
268269
add_test("filename" "./filename/binding.c" OFF)
269270
add_test("string" "./string/binding.c;./string/test_null.c" OFF)
271+
target_compile_definitions("string" PRIVATE "NAPI_EXPERIMENTAL")
270272
add_test("property" "./property/binding.c" OFF)
271273
add_test("promise" "./promise/binding.c" OFF)
272274
add_test("object" "./object/test_null.c;./object/test_object.c" OFF)

packages/test/string/binding.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
#include <js_native_api.h>
12
#include <limits.h> // INT_MAX
23

34
#if !defined(__wasm__) || (defined(__EMSCRIPTEN__) || defined(__wasi__))
@@ -25,8 +26,6 @@ size_t strlen(const char *s)
2526
}
2627
#endif
2728

28-
#define NAPI_EXPERIMENTAL
29-
#include <js_native_api.h>
3029
#include "../common.h"
3130
#include "../entry_point.h"
3231
#include "test_null.h"

0 commit comments

Comments
 (0)