Skip to content

Commit 05abd54

Browse files
omerktztpoisseau
authored andcommitted
cli: remove deprecated V8 flag
Remove the `--huge-max-old-generation-size` V8 flag from the `NODE_OPTIONS` allowlist. That flag was recently deprecated (it currently remains as nop, see crrev.com/c/5831467) and will soon be completely removed. PR-URL: nodejs#54761 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent a87b578 commit 05abd54

File tree

3 files changed

+0
-9
lines changed

3 files changed

+0
-9
lines changed

doc/api/cli.md

-3
Original file line numberDiff line numberDiff line change
@@ -3122,7 +3122,6 @@ V8 options that are allowed are:
31223122
* `--disallow-code-generation-from-strings`
31233123
* `--enable-etw-stack-walking`
31243124
* `--expose-gc`
3125-
* `--huge-max-old-generation-size`
31263125
* `--interpreted-frames-native-stack`
31273126
* `--jitless`
31283127
* `--max-old-space-size`
@@ -3456,8 +3455,6 @@ documented here:
34563455

34573456
### `--harmony-shadow-realm`
34583457

3459-
### `--huge-max-old-generation-size`
3460-
34613458
### `--jitless`
34623459

34633460
### `--interpreted-frames-native-stack`

src/node_options.cc

-5
Original file line numberDiff line numberDiff line change
@@ -904,11 +904,6 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
904904
"disallow eval and friends",
905905
V8Option{},
906906
kAllowedInEnvvar);
907-
AddOption("--huge-max-old-generation-size",
908-
"increase default maximum heap size on machines with 16GB memory "
909-
"or more",
910-
V8Option{},
911-
kAllowedInEnvvar);
912907
AddOption("--jitless",
913908
"disable runtime allocation of executable memory",
914909
V8Option{},

test/parallel/test-cli-node-options.js

-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ if (common.hasCrypto) {
7070
expect('--abort_on-uncaught_exception', 'B\n');
7171
expect('--disallow-code-generation-from-strings', 'B\n');
7272
expect('--expose-gc', 'B\n');
73-
expect('--huge-max-old-generation-size', 'B\n');
7473
expect('--jitless', 'B\n');
7574
expect('--max-old-space-size=0', 'B\n');
7675
expect('--max-semi-space-size=0', 'B\n');

0 commit comments

Comments
 (0)