Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterSphere API #21

Closed
tzaeschke opened this issue Apr 6, 2022 · 0 comments
Closed

FilterSphere API #21

tzaeschke opened this issue Apr 6, 2022 · 0 comments

Comments

@tzaeschke
Copy link
Owner

The constructor of FilterSphere is a bit unusual and probably wrong:

    FilterSphere(
        const KeyExternal& center,
        const ScalarExternal& radius,
  • radius should probably not be a reference. It could be a universal reference though, in case that is desirable. It should probably
    mainly accept primitive values.
  • radius should probably be double or float
  • center should probably be a universal reference to accept rvalues. If it is a reference, we should actually store it as a reference and not copy it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant