Use ReplaceAll instead of Replace with -1 pos arg (#1195)

sashamelentyev · web-flow · commit ed5598a9e26d · 2022-11-06T13:00:46.000-08:00
diff --git a/internal/readme/readme.go b/internal/readme/readme.go
@@ -140,7 +140,7 @@ func getBenchmarkRow(
 	if len(split) < 5 {
 		return nil, fmt.Errorf("unknown benchmark line: %s", line)
 	}
-	duration, err := time.ParseDuration(strings.Replace(strings.TrimSuffix(strings.TrimSpace(split[2]), "/op"), " ", "", -1))
+	duration, err := time.ParseDuration(strings.ReplaceAll(strings.TrimSuffix(strings.TrimSpace(split[2]), "/op"), " ", ""))
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ func getBenchmarkRow(`
`140`	`140`	`if len(split) < 5 {`
`141`	`141`	`return nil, fmt.Errorf("unknown benchmark line: %s", line)`
`142`	`142`	`}`
`143`		`- duration, err := time.ParseDuration(strings.Replace(strings.TrimSuffix(strings.TrimSpace(split[2]), "/op"), " ", "", -1))`
	`143`	`+ duration, err := time.ParseDuration(strings.ReplaceAll(strings.TrimSuffix(strings.TrimSpace(split[2]), "/op"), " ", ""))`
`144`	`144`	`if err != nil {`
`145`	`145`	`return nil, err`
`146`	`146`	`}`