Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: CapsLock interferes with hotkeys (specifically undo Ctrl+Z) #4055

Closed
1 of 2 tasks
Nantris opened this issue May 17, 2023 · 3 comments · Fixed by #4132
Closed
1 of 2 tasks

[Bug]: CapsLock interferes with hotkeys (specifically undo Ctrl+Z) #4055

Nantris opened this issue May 17, 2023 · 3 comments · Fixed by #4132
Assignees
@bdbch @svenadlung
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug

Comments

@Nantris
Copy link
Contributor

Nantris commented May 17, 2023

Which packages did you experience the bug in?

core

What Tiptap version are you using?

2.0.3

What’s the bug you are facing?

Activated CapsLock prevents undo from occurring (at least on Linux, but presumably everywhere)

What browser are you using?

Chrome

Code example

https://tiptap.dev/api/extensions/history#usage

What did you expect to happen?

CapsLock should never interfere with any defined hotkey

Anything to add? (optional)

The handling of hotkeys needs to be prioritized for 2.2.0 in my humble opinion. There are a a few edge cases in the core example code that affect basic usage but probably don't require a lot of work.

Related #4006

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@Nantris Nantris added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug labels May 17, 2023
@Nantris Nantris mentioned this issue Jun 7, 2023
Open
@Nantris
Copy link
Contributor Author

Nantris commented Jun 7, 2023

I've created #4111 to track the related hotkey failures that affect TipTap by default.

@Nantris Nantris mentioned this issue Jun 14, 2023
Merged
4 tasks
@Nantris
Copy link
Contributor Author

Nantris commented Jun 14, 2023

This should be fixed by #4132

@vinzdef vinzdef mentioned this issue Oct 30, 2024
Open
1 task
vinzdef referenced this issue Oct 30, 2024
@webkadiz
fix(history): use correct shortcuts for undo/redo
520ce79
@vinzdef
Copy link

vinzdef commented Oct 30, 2024

This bug is back @Nantris #5789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdbch bdbch

@svenadlung svenadlung

Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mod+z/mod+y failed with capslock Nantris/tiptap
4 participants
@vinzdef @bdbch @Nantris @svenadlung