Skip to content

Commit 2a65604

Browse files
authored
Merge pull request #67 from uploadcare/66-jackson-upgrade
Upgrade jackson-databinc to resolve deserialization issues.
2 parents 7e66f79 + 882a9fe commit 2a65604

File tree

3 files changed

+32
-2
lines changed

3 files changed

+32
-2
lines changed

build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ java {
2020
dependencies {
2121
implementation("org.apache.httpcomponents:httpclient:4.5.13")
2222
implementation("org.apache.httpcomponents:httpmime:4.5.13")
23-
implementation("com.fasterxml.jackson.core:jackson-databind:2.12.6.1")
23+
implementation("com.fasterxml.jackson.core:jackson-databind:2.16.2")
2424
implementation("commons-codec:commons-codec:1.10")
2525
implementation("commons-io:commons-io:2.7")
2626
implementation("com.sun.activation:javax.activation:1.2.0")

gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Project-wide Gradle settings.
2-
version=3.5.2
2+
version=3.5.3-SNAPSHOT
33

44
# Signature key id
55
signing.gnupg.keyName=A0835D6B27223852
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
package com.uploadcare.api;
2+
3+
import com.fasterxml.jackson.databind.DeserializationFeature;
4+
import com.fasterxml.jackson.databind.ObjectMapper;
5+
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
6+
import org.junit.Assert;
7+
import org.junit.Test;
8+
9+
public class FileTest
10+
{
11+
12+
@Test
13+
public void enumFails() throws Exception {
14+
String json = "{ \"color_mode\": \"RGBa\"}";
15+
16+
// duplicate the way the mapper is configured in uploadcare
17+
ObjectMapper mapper = new ObjectMapper();
18+
mapper.setPropertyNamingStrategy(PropertyNamingStrategies.SNAKE_CASE);
19+
mapper.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES);
20+
21+
Bug bug = mapper.readValue(json, Bug.class);
22+
23+
Assert.assertTrue("Color mode was not properly converted!", File.ColorMode.RGBa.equals(bug.colorMode));
24+
}
25+
26+
static class Bug {
27+
public File.ColorMode colorMode;
28+
}
29+
30+
}

0 commit comments

Comments
 (0)