Skip to content

Commit 215ccd5

Browse files
joyeecheungV8 LUCI CQ
authored and
V8 LUCI CQ
committed
Use FlagValue::value() in SLOW_DCHECK
Previously SLOW_DCHECK used the non-constexpr bool() operator of FlagValue, which cannot be used in constexpr. Switch to FlagValue::value() instead for make it compile in constexpr. Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495 Reviewed-by: Jakob Linke <jgruber@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#86611}
1 parent 9041901 commit 215ccd5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/common/checks.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
#ifdef ENABLE_SLOW_DCHECKS
1717
#define SLOW_DCHECK(condition) \
18-
CHECK(!v8::internal::v8_flags.enable_slow_asserts || (condition))
18+
CHECK(!v8::internal::v8_flags.enable_slow_asserts.value() || (condition))
1919
#define SLOW_DCHECK_IMPLIES(lhs, rhs) SLOW_DCHECK(!(lhs) || (rhs))
2020
#else
2121
#define SLOW_DCHECK(condition) ((void)0)

0 commit comments

Comments
 (0)