Skip to content

Commit 958b761

Browse files
Matheus MarchiniCommit Bot
Matheus Marchini
authored and
Commit Bot
committed
[postmortem] add postmortem metadata for symbols
As discussed in nodejs/llnode#156, we need postmortem metadata for Symbols to properly print Symbol property names in postmortem debugging tools. Patch suggested by Ben Noordhuis (nodejs/llnode#156 (comment)). R=bmeurer@google.com, yangguo@google.com Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118 Reviewed-on: https://chromium-review.googlesource.com/1205052 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55632}
1 parent 84121f5 commit 958b761

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

BUILD.gn

+2
Original file line numberDiff line numberDiff line change
@@ -859,6 +859,8 @@ action("postmortem-metadata") {
859859
"src/objects/js-regexp-string-iterator.h",
860860
"src/objects/map.h",
861861
"src/objects/map-inl.h",
862+
"src/objects/name.h",
863+
"src/objects/name-inl.h",
862864
"src/objects/scope-info.h",
863865
"src/objects/script.h",
864866
"src/objects/script-inl.h",

tools/gen-postmortem-metadata.py

+1-6
Original file line numberDiff line numberDiff line change
@@ -417,15 +417,10 @@ def load_objects_from_file(objfilename, checktypes):
417417
# way around.
418418
#
419419
for type in types:
420-
#
421-
# Symbols and Strings are implemented using the same classes.
422-
#
423-
usetype = re.sub('SYMBOL_', 'STRING_', type);
424-
425420
#
426421
# REGEXP behaves like REG_EXP, as in JS_REGEXP_TYPE => JSRegExp.
427422
#
428-
usetype = re.sub('_REGEXP_', '_REG_EXP_', usetype);
423+
usetype = re.sub('_REGEXP_', '_REG_EXP_', type);
429424

430425
#
431426
# Remove the "_TYPE" suffix and then convert to camel case,

0 commit comments

Comments
 (0)