Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move platform-specific signal handling code out of main.rs #1383

Closed
ghost opened this issue Dec 17, 2019 · 0 comments · Fixed by #3185
Closed

Move platform-specific signal handling code out of main.rs #1383

ghost opened this issue Dec 17, 2019 · 0 comments · Fixed by #3185
Assignees
@ktff
Labels
type: tech debt A code change that does not add user value.

Comments

@ghost
Copy link

ghost commented Dec 17, 2019

After Windows support was added, the main.rs started to contain a lot of duplicated code for handling interruption signals on cfg(unix) and cfg(windows). We need to factor it out by putting it to a separate source file or even a new crate in lib. See #1219 (comment) for details.
@ghost ghost added type: tech debt A code change that does not add user value. domain: platforms labels Dec 17, 2019
@ghost ghost mentioned this issue Dec 17, 2019
Merged
@ktff ktff mentioned this issue Jan 3, 2020
Merged
1 task
@lukesteensen lukesteensen mentioned this issue Feb 9, 2020
Closed
@binarylogic binarylogic added this to the Tech-debt payment #1: Code organization milestone Feb 22, 2020
@binarylogic binarylogic removed this from the Tech-Debt Payment #1: Code Organization milestone Jul 19, 2020
@ktff ktff mentioned this issue Jul 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktff ktff

Labels
type: tech debt A code change that does not add user value.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Moves platform-specific signal code out of main vectordotdev/vector
2 participants
@binarylogic @ktff