Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http client factory method to SinkContext #1408

Closed
LucioFranco opened this issue Dec 20, 2019 · 1 comment
Closed

Add http client factory method to SinkContext #1408

LucioFranco opened this issue Dec 20, 2019 · 1 comment
Assignees
@LucioFranco
Labels
domain: networking Anything related to Vector's networking domain: sinks Anything related to the Vector's sinks type: tech debt A code change that does not add user value.

Comments

@LucioFranco
Copy link
Contributor

We should add a convenience method to SinkContext to return a hyper::Client with the configured connector and resolver. We can also fold all of our http clients into one at this point too.
@LucioFranco LucioFranco added type: tech debt A code change that does not add user value. domain: networking Anything related to Vector's networking domain: sinks Anything related to the Vector's sinks labels Dec 20, 2019
@LucioFranco LucioFranco mentioned this issue Dec 20, 2019
Merged
@lukesteensen lukesteensen mentioned this issue Feb 9, 2020
Closed
@binarylogic binarylogic added this to the Tech-debt payment #1: Simplify sinks milestone Feb 22, 2020
@LucioFranco LucioFranco self-assigned this Feb 27, 2020
@LucioFranco
Copy link
Contributor Author

After much reflection this isn't worth it since constructing a http client is now much easier.

@binarylogic binarylogic removed this from the Tech-Debt Payment #1: Simplify Sinks milestone Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucioFranco LucioFranco

Labels
domain: networking Anything related to Vector's networking domain: sinks Anything related to the Vector's sinks type: tech debt A code change that does not add user value.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@binarylogic @LucioFranco