-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate file descriptor use with tokio 0.2 #1695
Comments
And to clarify a few things, I found that when I disabled the tokio 0.2 IO driver that the high fd usage went away. So this would be another area to check. |
Another note, one thing I found was if we disabled the io driver here https://github.com/tokio-rs/tokio-compat/blob/master/src/runtime/threadpool/builder.rs#L172 it seemed to fix the issue for me. Leading me to believe this was with the 0.2 io driver. I would suggest cloning tokio-compat locally, and patching it into vector. If you have questions feel free to reach out. check https://docs.rs/tokio/0.2.11/tokio/runtime/struct.Builder.html#method.enable_io docs and the general tokio 0.2 builder docs. |
Solved as part of #1922 via tokio-rs/tokio-compat#28 |
Nice work |
As explained in #1142, we want to upgrade our underlying runtime to tokio 0.2 for better performance, more modern interfaces, etc. The
tokio-compat
runtime gives us an incremental path for that upgrade, so we'd like to use that as a first step.In some preliminary experiments switching to
tokio-compat
, @LucioFranco found an issue where the new runtime caused significantly increased use of file descriptors, particularly during test runs. Before we merge any changes to master, we should try to reproduce and measure this effect so we can evaluate its impact both for users and contributors.Here's a rough plan of attack:
tokio-compat
(see Upgrade totokio v0.2
andstd::future::Future
#1142) and get tests passing.cargo test --features docker
across master and the new branch.Once we have some data to compare, we can evaluate the impact and see how we want to proceed.
The text was updated successfully, but these errors were encountered: