-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on tokio 0.1 #2945
Comments
New dependency tree (ae53b88):
After pulsar update (#2977) only vector will depend from Edit: pulsar merged (https://github.com/timberio/vector/tree/ccbb802c010c6109240a14be44b3c30dbae73564):
|
@ktff I'll start on updating
|
@fanatid I'll start with |
@fanatid I'll start with |
@ktff I'm going remove https://github.com/timberio/vector/blob/6a6c390b7e7af2b977ff088245e94e31cefb7640/src/stream.rs#L40 and update affected code. |
@ktff looks like not a lot of tokio01 usage left, I do not think that it cost divide files, so I'll take rest. |
@fanatid how is this going? Need any extra hands? |
Need only update my previous TLS PR #3188 and we should be able remove tokio:0.1. Should finish soon, no need help right now I think. Thanks! |
This is a prerequisite for removing
tokio-compat
and using some nice things like the#[tokio::test]
macro.First, we need to upgrade dependencies that rely on tokio 0.1 (some of these are in progress):
Second, we need to remove tokio 0.1 types from our sources, sinks, and transforms. These consist mostly of timers and IO types like sockets that we should switch to the equivalent tokio 0.2 types. Where relevant and not too invasive, this can also be a good time to do some light updates away from futures 0.1 combinators and towards async/await. The following is a rough list of files that import
tokio01
:benches/http.rs
#3107)tokio
0.1
tocargo-deny
This work should be very easy to work on in parallel, so feel free to grab a dependency or a specific file and go to work on a PR.
The text was updated successfully, but these errors were encountered: