Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2017 Census #171

Closed
montyvesselinov opened this issue May 12, 2020 · 8 comments
Closed

Update to 2017 Census #171

montyvesselinov opened this issue May 12, 2020 · 8 comments

Comments

@montyvesselinov
Copy link

Any plans to update us-10m to represent the latest county FIPS.

https://cdn.jsdelivr.net/npm/us-atlas@2/us/10m.json

@domoritz
Copy link
Member

We could do that. Wanna send a pull request?

@montyvesselinov
Copy link
Author

Sure! Do you have examples how to convert to vega topo json format somewhere?

@jheer
Copy link
Member

jheer commented May 13, 2020

One thing to keep in mind is what examples and test specifications in Vega and/or Vega-Lite may be using a dataset before we make any updates. Will it break existing test cases? In the case of geo data, might the inclusion of different ids/regions break joins (lookups) with other (also "outdated") data sets?

While Vega keeps a separate folder of data sets for test cases to guard against breakage due to vega-datasets updates, the online examples do pull from vega-datasets and so could be subject to breakage. For example, the unemployment choropleth might break with updated data to us-10m.json.

I'm (in general) supportive of using more recent examples, but I want to make sure we are keeping these downstream effects in mind. Adding new files with timestamps is probably preferable to overwriting existing files. Thanks!

@jwoLondon
Copy link
Contributor

Perhaps timestamp the file names (us10m_2017.json etc.).

@montyvesselinov
Copy link
Author

Yes, it will be better to call it us10m_2017.json. The FIPS change regularly.

Do you have an example how to convert?

@domoritz
Copy link
Member

I’d prefer not to have multiple versions of the same data unless it causes issues with the existing examples.

@domoritz
Copy link
Member

@montyvesselinov I want to cut a 2.0 release and include this update. I think the only way forward is to also include an updates unemployment dataset (and include a year such as unemployment_2017.csv. Can you send a pull request in the next few days?

@domoritz domoritz mentioned this issue May 31, 2020
4 tasks
@domoritz
Copy link
Member

Closing as we are moving to v2 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants