Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HyperCLI and WSL #3432

Open
Stanzilla opened this issue Jan 23, 2019 · 2 comments
Open

HyperCLI and WSL #3432

Stanzilla opened this issue Jan 23, 2019 · 2 comments
Labels
help wanted Contributions wanted towards the issue 🖼 Platform: Windows Issue pertains to Windows 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper

Comments

@Stanzilla
Copy link
Contributor

As a follow up to #2375

This https://github.com/zeit/hyper/blob/master/build/win/hyper#L8 can probably be fixed now by using WSLENV https://blogs.msdn.microsoft.com/commandline/2017/12/22/share-environment-vars-between-wsl-and-windows/
@Stanzilla Stanzilla added 🖼 Platform: Windows Issue pertains to Windows help wanted Contributions wanted towards the issue 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper labels Jan 23, 2019
@chabou
Copy link
Contributor

chabou commented Jan 23, 2019

The hardest would be to detect the Windows version to show or not the warning

@TomClancyIsDead
Copy link

cmd.exe /c "systeminfo" | grep "^OS Version" gives you the OS build # from within Hyper and WSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Contributions wanted towards the issue 🖼 Platform: Windows Issue pertains to Windows 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Stanzilla @chabou @TomClancyIsDead