strlen optimization: use constexpr instead of runtime-constant

ferdymercury · jenkins · commit 6555674b1881 · 2024-12-09T14:59:05.000+01:00
strlen cannot be a constexpr in all platforms otherwise.
diff --git a/lib/Interpreter/ForwardDeclPrinter.cpp b/lib/Interpreter/ForwardDeclPrinter.cpp
@@ -192,7 +192,7 @@ namespace cling {
        // FIXME: Once the C++ modules replaced the forward decls, remove this.
        if (D->getASTContext().getLangOpts().Modules &&
            llvm::StringRef(includeText).starts_with("include ")) {
-         includeText += strlen("include ");
+         includeText += std::char_traits<char>::length("include ");
        }
 
        assert((includeText[0] == '<' || includeText[0] == '"') &&

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ namespace cling {`
`192`	`192`	`// FIXME: Once the C++ modules replaced the forward decls, remove this.`
`193`	`193`	`if (D->getASTContext().getLangOpts().Modules &&`
`194`	`194`	`llvm::StringRef(includeText).starts_with("include ")) {`
`195`		`- includeText += strlen("include ");`
	`195`	`+ includeText += std::char_traits<char>::length("include ");`
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`assert((includeText[0] == '<' \|\| includeText[0] == '"') &&`