Fix

Author: danog

src/Psalm/Internal/DataFlow/DataFlowNode.php

@@ -48,7 +48,7 @@ public static function make(
             $unspecialized_id = null;
         } else {
             $unspecialized_id = $id;
-            $id .= '-' . $specialization_key;
+            $id .= ' specialized in ' . $specialization_key;
         }
         return new self(
             $id,
@@ -93,7 +93,7 @@ public static function getForAssignment(
         ?string $specialization_key = null,
     ): self {
         $label = $var_id;
-        $var_id .= ':' . $assignment_location->file_name
+        $var_id .= ' from ' . strtolower($assignment_location->file_name)
             . ':' . $assignment_location->raw_file_start
             . '-' . $assignment_location->raw_file_end;
 

tests/fixtures/expected_taint_graph.dot

@@ -1,20 +1,20 @@
 digraph Taints {
-	"$_GET:src/FileWithErrors.php:414" -> "$_GET['abc']-src/FileWithErrors.php:414-418"
-	"$_GET:src/FileWithErrors.php:441" -> "$_GET['abc']-src/FileWithErrors.php:441-445"
-	"$_GET:src/FileWithErrors.php:457" -> "$_GET['abc']-src/FileWithErrors.php:457-461"
-	"$_GET['abc']-src/FileWithErrors.php:441-445" -> "call to is_string-src/FileWithErrors.php:441-452"
-	"$_GET['abc']-src/FileWithErrors.php:457-461" -> "call to echo-src/FileWithErrors.php:408-474"
-	"$s-src/FileWithErrors.php:110-111" -> "variable-use" -> "acme\sampleproject\bar"
-	"$s-src/FileWithErrors.php:163-164" -> "variable-use" -> "acme\sampleproject\baz"
-	"$s-src/FileWithErrors.php:216-217" -> "variable-use" -> "acme\sampleproject\bat"
-	"$s-src/FileWithErrors.php:270-271" -> "variable-use" -> "acme\sampleproject\bang"
-	"acme\sampleproject\bang#1" -> "$s-src/FileWithErrors.php:270-271"
-	"acme\sampleproject\bar#1" -> "$s-src/FileWithErrors.php:110-111"
-	"acme\sampleproject\bat#1" -> "$s-src/FileWithErrors.php:216-217"
-	"acme\sampleproject\baz#1" -> "$s-src/FileWithErrors.php:163-164"
-	"acme\sampleproject\foo#1" -> "$_s-src/FileWithErrors.php:57-59"
-	"call to echo-src/FileWithErrors.php:336-368" -> "echo#1-src/filewitherrors.php:331"
-	"call to echo-src/FileWithErrors.php:408-474" -> "echo#1-src/filewitherrors.php:403"
-	"call to is_string-src/FileWithErrors.php:441-452" -> "is_string#1-src/filewitherrors.php:431"
-	"coalesce-src/FileWithErrors.php:346-367" -> "call to echo-src/FileWithErrors.php:336-368"
+	"$_GET specialized in src/FileWithErrors.php:414" -> "$_GET['abc'] from src/filewitherrors.php:414-418"
+	"$_GET specialized in src/FileWithErrors.php:441" -> "$_GET['abc'] from src/filewitherrors.php:441-445"
+	"$_GET specialized in src/FileWithErrors.php:457" -> "$_GET['abc'] from src/filewitherrors.php:457-461"
+	"$_GET['abc'] from src/filewitherrors.php:441-445" -> "call to is_string from src/filewitherrors.php:441-452"
+	"$_GET['abc'] from src/filewitherrors.php:457-461" -> "call to echo from src/filewitherrors.php:408-474"
+	"$s from src/filewitherrors.php:110-111" -> "variable-use" -> "acme\sampleproject\bar"
+	"$s from src/filewitherrors.php:163-164" -> "variable-use" -> "acme\sampleproject\baz"
+	"$s from src/filewitherrors.php:216-217" -> "variable-use" -> "acme\sampleproject\bat"
+	"$s from src/filewitherrors.php:270-271" -> "variable-use" -> "acme\sampleproject\bang"
+	"acme\sampleproject\bang#1" -> "$s from src/filewitherrors.php:270-271"
+	"acme\sampleproject\bar#1" -> "$s from src/filewitherrors.php:110-111"
+	"acme\sampleproject\bat#1" -> "$s from src/filewitherrors.php:216-217"
+	"acme\sampleproject\baz#1" -> "$s from src/filewitherrors.php:163-164"
+	"acme\sampleproject\foo#1" -> "$_s from src/filewitherrors.php:57-59"
+	"call to echo from src/filewitherrors.php:336-368" -> "echo#1 specialized in src/filewitherrors.php:331"
+	"call to echo from src/filewitherrors.php:408-474" -> "echo#1 specialized in src/filewitherrors.php:403"
+	"call to is_string from src/filewitherrors.php:441-452" -> "is_string#1 specialized in src/filewitherrors.php:431"
+	"coalesce from src/filewitherrors.php:346-367" -> "call to echo from src/filewitherrors.php:336-368"
 }