Merge pull request #10318 from danog/finalize

Finalize all internal classes

Author: orklah

examples/TemplateChecker.php

@@ -30,7 +30,7 @@
 use function strtolower;
 use function trim;
 
-class TemplateAnalyzer extends Psalm\Internal\Analyzer\FileAnalyzer
+final class TemplateAnalyzer extends Psalm\Internal\Analyzer\FileAnalyzer
 {
     const VIEW_CLASS = 'Your\\View\\Class';
 

examples/TemplateScanner.php

@@ -14,7 +14,7 @@
 use function preg_match;
 use function trim;
 
-class TemplateScanner extends Psalm\Internal\Scanner\FileScanner
+final class TemplateScanner extends Psalm\Internal\Scanner\FileScanner
 {
     const VIEW_CLASS = 'Your\\View\\Class';
 

examples/plugins/ClassUnqualifier.php

@@ -12,7 +12,7 @@
 use function strpos;
 use function strtolower;
 
-class ClassUnqualifier implements AfterClassLikeExistenceCheckInterface
+final class ClassUnqualifier implements AfterClassLikeExistenceCheckInterface
 {
     public static function afterClassLikeExistenceCheck(
         AfterClassLikeExistenceCheckEvent $event

examples/plugins/FunctionCasingChecker.php

@@ -21,7 +21,7 @@
 /**
  * Checks that functions and methods are correctly-cased
  */
-class FunctionCasingChecker implements AfterFunctionCallAnalysisInterface, AfterMethodCallAnalysisInterface
+final class FunctionCasingChecker implements AfterFunctionCallAnalysisInterface, AfterMethodCallAnalysisInterface
 {
     public static function afterMethodCallAnalysis(AfterMethodCallAnalysisEvent $event): void
     {
@@ -99,6 +99,6 @@ public static function afterFunctionCallAnalysis(AfterFunctionCallAnalysisEvent
     }
 }
 
-class IncorrectFunctionCasing extends PluginIssue
+final class IncorrectFunctionCasing extends PluginIssue
 {
 }

examples/plugins/InternalChecker.php

@@ -12,7 +12,7 @@
 
 use function strpos;
 
-class InternalChecker implements AfterClassLikeAnalysisInterface
+final class InternalChecker implements AfterClassLikeAnalysisInterface
 {
     /** @return null|false */
     public static function afterStatementAnalysis(AfterClassLikeAnalysisEvent $event): ?bool

examples/plugins/PreventFloatAssignmentChecker.php

@@ -12,7 +12,7 @@
 /**
  * Prevents any assignment to a float value
  */
-class PreventFloatAssignmentChecker implements AfterExpressionAnalysisInterface
+final class PreventFloatAssignmentChecker implements AfterExpressionAnalysisInterface
 {
     /**
      * Called after an expression has been checked
@@ -40,6 +40,6 @@ public static function afterExpressionAnalysis(AfterExpressionAnalysisEvent $eve
     }
 }
 
-class NoFloatAssignment extends PluginIssue
+final class NoFloatAssignment extends PluginIssue
 {
 }

examples/plugins/SafeArrayKeyChecker.php

@@ -7,7 +7,7 @@
 use Psalm\Plugin\EventHandler\Event\AddRemoveTaintsEvent;
 use Psalm\Plugin\EventHandler\RemoveTaintsInterface;
 
-class SafeArrayKeyChecker implements RemoveTaintsInterface
+final class SafeArrayKeyChecker implements RemoveTaintsInterface
 {
     /**
      * Called to see what taints should be removed

examples/plugins/StringChecker.php

@@ -16,7 +16,7 @@
 use function strpos;
 use function strtolower;
 
-class StringChecker implements AfterExpressionAnalysisInterface
+final class StringChecker implements AfterExpressionAnalysisInterface
 {
     /**
      * Called after an expression has been checked

examples/plugins/composer-based/echo-checker/EchoChecker.php

@@ -11,7 +11,7 @@
 use Psalm\Type\Atomic\TLiteralString;
 use Psalm\Type\Atomic\TString;
 
-class EchoChecker implements AfterStatementAnalysisInterface
+final class EchoChecker implements AfterStatementAnalysisInterface
 {
     /**
      * Called after a statement has been checked

examples/plugins/composer-based/echo-checker/PluginEntryPoint.php

@@ -6,7 +6,7 @@
 use Psalm\Plugin\RegistrationInterface;
 use SimpleXMLElement;
 
-class PluginEntryPoint implements PluginEntryPointInterface
+final class PluginEntryPoint implements PluginEntryPointInterface
 {
     public function __invoke(RegistrationInterface $registration, ?SimpleXMLElement $config = null): void
     {

src/Psalm/Internal/Algebra.php

@@ -24,7 +24,7 @@
 /**
  * @internal
  */
-class Algebra
+final class Algebra
 {
     /**
      * @param array<string, non-empty-list<non-empty-list<Assertion>>>  $all_types

src/Psalm/Internal/Algebra/FormulaGenerator.php

@@ -21,7 +21,7 @@
 /**
  * @internal
  */
-class FormulaGenerator
+final class FormulaGenerator
 {
      /**
      * @return list<Clause>

src/Psalm/Internal/Analyzer/AlgebraAnalyzer.php

@@ -20,7 +20,7 @@
 /**
  * @internal
  */
-class AlgebraAnalyzer
+final class AlgebraAnalyzer
 {
     /**
      * This looks to see if there are any clauses in one formula that contradict

src/Psalm/Internal/Analyzer/AttributesAnalyzer.php

@@ -33,7 +33,7 @@
 /**
  * @internal
  */
-class AttributesAnalyzer
+final class AttributesAnalyzer
 {
     private const TARGET_DESCRIPTIONS = [
         1 => 'class',

src/Psalm/Internal/Analyzer/ClassAnalyzer.php

@@ -106,7 +106,7 @@
 /**
  * @internal
  */
-class ClassAnalyzer extends ClassLikeAnalyzer
+final class ClassAnalyzer extends ClassLikeAnalyzer
 {
     /**
      * @var array<string, Union>

src/Psalm/Internal/Analyzer/ClassLikeNameOptions.php

@@ -5,7 +5,7 @@
 /**
  * @internal
  */
-class ClassLikeNameOptions
+final class ClassLikeNameOptions
 {
     public bool $inferred;
 

src/Psalm/Internal/Analyzer/ClosureAnalyzer.php

@@ -27,7 +27,7 @@
  * @internal
  * @extends FunctionLikeAnalyzer<PhpParser\Node\Expr\Closure|PhpParser\Node\Expr\ArrowFunction>
  */
-class ClosureAnalyzer extends FunctionLikeAnalyzer
+final class ClosureAnalyzer extends FunctionLikeAnalyzer
 {
     /**
      * @param PhpParser\Node\Expr\Closure|PhpParser\Node\Expr\ArrowFunction $function

src/Psalm/Internal/Analyzer/CommentAnalyzer.php

@@ -41,7 +41,7 @@
 /**
  * @internal
  */
-class CommentAnalyzer
+final class CommentAnalyzer
 {
     public const TYPE_REGEX = '(\??\\\?[\(\)A-Za-z0-9_&\<\.=,\>\[\]\-\{\}:|?\\\\]*|\$[a-zA-Z_0-9_]+)';
 

src/Psalm/Internal/Analyzer/DataFlowNodeData.php

@@ -8,7 +8,7 @@
  * @psalm-immutable
  * @internal
  */
-class DataFlowNodeData
+final class DataFlowNodeData
 {
     use ImmutableNonCloneableTrait;
 

src/Psalm/Internal/Analyzer/FunctionAnalyzer.php

@@ -14,7 +14,7 @@
  * @internal
  * @extends FunctionLikeAnalyzer<PhpParser\Node\Stmt\Function_>
  */
-class FunctionAnalyzer extends FunctionLikeAnalyzer
+final class FunctionAnalyzer extends FunctionLikeAnalyzer
 {
     public function __construct(PhpParser\Node\Stmt\Function_ $function, SourceAnalyzer $source)
     {

src/Psalm/Internal/Analyzer/FunctionLike/ReturnTypeAnalyzer.php

@@ -63,7 +63,7 @@
 /**
  * @internal
  */
-class ReturnTypeAnalyzer
+final class ReturnTypeAnalyzer
 {
     /**
      * @param Closure|Function_|ClassMethod|ArrowFunction $function

src/Psalm/Internal/Analyzer/FunctionLike/ReturnTypeCollector.php

@@ -24,7 +24,7 @@
  *
  * @internal
  */
-class ReturnTypeCollector
+final class ReturnTypeCollector
 {
     /**
      * Gets the return types from a list of statements

src/Psalm/Internal/Analyzer/InterfaceAnalyzer.php

@@ -25,7 +25,7 @@
 /**
  * @internal
  */
-class InterfaceAnalyzer extends ClassLikeAnalyzer
+final class InterfaceAnalyzer extends ClassLikeAnalyzer
 {
     public function __construct(
         PhpParser\Node\Stmt\Interface_ $interface,

src/Psalm/Internal/Analyzer/IssueData.php

@@ -9,7 +9,7 @@
 /**
  * @internal
  */
-class IssueData
+final class IssueData
 {
     public const SEVERITY_INFO = 'info';
     public const SEVERITY_ERROR = 'error';

src/Psalm/Internal/Analyzer/MethodAnalyzer.php

@@ -27,7 +27,7 @@
  * @internal
  * @extends FunctionLikeAnalyzer<PhpParser\Node\Stmt\ClassMethod>
  */
-class MethodAnalyzer extends FunctionLikeAnalyzer
+final class MethodAnalyzer extends FunctionLikeAnalyzer
 {
     // https://github.com/php/php-src/blob/a83923044c48982c80804ae1b45e761c271966d3/Zend/zend_enum.c#L77-L95
     private const FORBIDDEN_ENUM_METHODS = [

src/Psalm/Internal/Analyzer/MethodComparator.php

@@ -44,7 +44,7 @@
 /**
  * @internal
  */
-class MethodComparator
+final class MethodComparator
 {
     /**
      * @param  string[]         $suppressed_issues

src/Psalm/Internal/Analyzer/NamespaceAnalyzer.php

@@ -23,7 +23,7 @@
 /**
  * @internal
  */
-class NamespaceAnalyzer extends SourceAnalyzer
+final class NamespaceAnalyzer extends SourceAnalyzer
 {
     use CanAlias;
 

src/Psalm/Internal/Analyzer/ProjectAnalyzer.php

@@ -93,7 +93,7 @@
 /**
  * @internal
  */
-class ProjectAnalyzer
+final class ProjectAnalyzer
 {
     /**
      * Cached config

src/Psalm/Internal/Analyzer/ScopeAnalyzer.php

@@ -17,7 +17,7 @@
 /**
  * @internal
  */
-class ScopeAnalyzer
+final class ScopeAnalyzer
 {
     public const ACTION_END = 'END';
     public const ACTION_BREAK = 'BREAK';

src/Psalm/Internal/Analyzer/Statements/Block/DoAnalyzer.php

@@ -28,7 +28,7 @@
 /**
  * @internal
  */
-class DoAnalyzer
+final class DoAnalyzer
 {
     public static function analyze(
         StatementsAnalyzer $statements_analyzer,

src/Psalm/Internal/Analyzer/Statements/Block/ForAnalyzer.php

@@ -19,7 +19,7 @@
 /**
  * @internal
  */
-class ForAnalyzer
+final class ForAnalyzer
 {
     /**
      * @return  false|null

src/Psalm/Internal/Analyzer/Statements/Block/ForeachAnalyzer.php

@@ -74,7 +74,7 @@
 /**
  * @internal
  */
-class ForeachAnalyzer
+final class ForeachAnalyzer
 {
     /**
      * @return  false|null

src/Psalm/Internal/Analyzer/Statements/Block/IfConditionalAnalyzer.php

@@ -29,7 +29,7 @@
 /**
  * @internal
  */
-class IfConditionalAnalyzer
+final class IfConditionalAnalyzer
 {
     public static function analyze(
         StatementsAnalyzer $statements_analyzer,

src/Psalm/Internal/Analyzer/Statements/Block/IfElse/ElseAnalyzer.php

@@ -26,7 +26,7 @@
 /**
  * @internal
  */
-class ElseAnalyzer
+final class ElseAnalyzer
 {
     /**
      * @return false|null

src/Psalm/Internal/Analyzer/Statements/Block/IfElse/ElseIfAnalyzer.php

@@ -40,7 +40,7 @@
 /**
  * @internal
  */
-class ElseIfAnalyzer
+final class ElseIfAnalyzer
 {
     /**
      * @return false|null

src/Psalm/Internal/Analyzer/Statements/Block/IfElse/IfAnalyzer.php

@@ -46,7 +46,7 @@
 /**
  * @internal
  */
-class IfAnalyzer
+final class IfAnalyzer
 {
     /**
      * @param  array<string, Union> $pre_assignment_else_redefined_vars

src/Psalm/Internal/Analyzer/Statements/Block/IfElseAnalyzer.php

@@ -41,7 +41,7 @@
 /**
  * @internal
  */
-class IfElseAnalyzer
+final class IfElseAnalyzer
 {
     /**
      * System of type substitution and deletion

src/Psalm/Internal/Analyzer/Statements/Block/LoopAnalyzer.php

@@ -28,7 +28,7 @@
 /**
  * @internal
  */
-class LoopAnalyzer
+final class LoopAnalyzer
 {
     /**
      * Checks an array of statements in a loop

src/Psalm/Internal/Analyzer/Statements/Block/SwitchAnalyzer.php

@@ -21,7 +21,7 @@
 /**
  * @internal
  */
-class SwitchAnalyzer
+final class SwitchAnalyzer
 {
     public static function analyze(
         StatementsAnalyzer $statements_analyzer,

src/Psalm/Internal/Analyzer/Statements/Block/SwitchCaseAnalyzer.php

@@ -53,7 +53,7 @@
 /**
  * @internal
  */
-class SwitchCaseAnalyzer
+final class SwitchCaseAnalyzer
 {
     /**
      * @return null|false

src/Psalm/Internal/Analyzer/Statements/Block/TryAnalyzer.php

@@ -29,7 +29,7 @@
 /**
  * @internal
  */
-class TryAnalyzer
+final class TryAnalyzer
 {
     /**
      * @return  false|null

src/Psalm/Internal/Analyzer/Statements/Block/WhileAnalyzer.php

@@ -16,7 +16,7 @@
 /**
  * @internal
  */
-class WhileAnalyzer
+final class WhileAnalyzer
 {
     /**
      * @return  false|null