Combining a array value empty list with a non-empty list was returning a non-empty-list

Author: robchett

src/Psalm/Internal/Type/TypeCombiner.php

@@ -1358,9 +1358,7 @@ private static function handleKeyedArrayEntries(
         }
 
         if (!$combination->array_type_params || $combination->array_type_params[1]->isNever()) {
-            if (!$overwrite_empty_array
-                && $combination->array_type_params
-            ) {
+            if ($combination->array_type_params) {
                 foreach ($combination->objectlike_entries as &$objectlike_entry) {
                     $objectlike_entry = $objectlike_entry->setPossiblyUndefined(true);
                 }

tests/ArrayAssignmentTest.php

@@ -2048,6 +2048,15 @@ function getQueryParams(): array
                         return $queryParams;
                     }',
             ],
+            'AssignListToNonEmptyList' => [
+                'code' => '<?php
+                    /** @var array<int, non-empty-list<string>> $l*/
+                    $l = [];
+                    $l[] = [];',
+                'assertions' => [
+                    '$l===' => 'non-empty-array<int, list<string>>',
+                ],
+            ],
         ];
     }