Skip to content

Commit 52a6732

Browse files
authored
fix: await scanner (#11242)
1 parent 8043fe4 commit 52a6732

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

packages/vite/src/node/optimizer/optimizer.ts

+9-1
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,16 @@ async function createDepsOptimizer(
161161
let firstRunCalled = !!cachedMetadata
162162

163163
let postScanOptimizationResult: Promise<DepOptimizationResult> | undefined
164+
let discoverProjectDependenciesPromise:
165+
| Promise<Record<string, string>>
166+
| undefined
164167

165168
let optimizingNewDeps: Promise<DepOptimizationResult> | undefined
166169
async function close() {
167170
closed = true
171+
await discoverProjectDependenciesPromise?.catch(() => {
172+
/* ignore error for scanner because it's not important */
173+
})
168174
await postScanOptimizationResult
169175
await optimizingNewDeps
170176
}
@@ -202,7 +208,9 @@ async function createDepsOptimizer(
202208
try {
203209
debug(colors.green(`scanning for dependencies...`))
204210

205-
const deps = await discoverProjectDependencies(config)
211+
discoverProjectDependenciesPromise =
212+
discoverProjectDependencies(config)
213+
const deps = await discoverProjectDependenciesPromise
206214

207215
debug(
208216
colors.green(

playground/multiple-entrypoints/__tests__/multiple-entrypoints.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect, test } from 'vitest'
22
import { getColor, page, untilUpdated } from '~utils'
33

4-
test.skip('should have css applied on second dynamic import', async () => {
4+
test('should have css applied on second dynamic import', async () => {
55
await untilUpdated(() => page.textContent('.content'), 'Initial', true)
66
await page.click('.b')
77

0 commit comments

Comments
 (0)