TypeError: Cannot create property 'lineStyle' on boolean 'false'

[xbzhang2020]

Describe the bug

When I migrate my project from vue-cli to vite，I encounter some problems, like that:

I find out that the problem comes from code like that:

var toolip = {
  crosshairs: false,
};

toolip.crosshairs['lineStyle'] = {}

Though it is unprecise, the code can run rightly in browser and node:

Why vite throw TypeError? The code comes from a third-party library，so I'm not able to modify it. Coluld vite svole the problem? Thanks.

Reproduction

https://stackblitz.com/edit/vitejs-vite-ugzs6j?file=main.js

System Info

System:
    OS: macOS 12.4
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 29.70 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.6.1 - ~/.nvm/versions/node/v16.6.1/bin/node
    Yarn: 1.22.11 - ~/.nvm/versions/node/v16.6.1/bin/yarn
    npm: 7.20.3 - ~/.nvm/versions/node/v16.6.1/bin/npm
    Watchman: 2021.06.07.00 - /usr/local/bin/watchman
  Browsers:
    Chrome: 103.0.5060.134
    Edge: 103.0.1264.77
    Firefox: 103.0
    Safari: 15.5
  npmPackages:
    @vitejs/plugin-vue: ^2.0.0 => 2.3.3 
    vite: ^2.7.2 => 2.9.14

Used Package Manager

yarn

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[sapphi-red]

This is because your code does not work in strict mode. Also it is always strict mode inside ESM.
You could run the following code in devtools or rename src/test.js to src/test.mjs to reproduce it.

function f() {
    "use strict";
    var toolip = {
      crosshairs: false,
    };
    
    toolip.crosshairs['lineStyle'] = {};
    console.log(toolip);
}
f()

Since Vite outputs with ESM, I think this cannot be supported.

For a workaround, I think patch-package or pnpm patch could be used.

[xbzhang2020]

Ohh! I get it. Thank you very much.