Skip to content

Commit 01d3a3d

Browse files
committed
[CUDA] Only allow NVIDIA offload-arch during CUDA compilation.
Otherwise, if someone specifies a valid AMD arch, we may end up triggering an assertion on unexpected arch later on. Differential Revision: https://reviews.llvm.org/D105295
1 parent 6245252 commit 01d3a3d

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

clang/lib/Driver/Driver.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -2785,7 +2785,7 @@ class OffloadingActionBuilder final {
27852785

27862786
StringRef getCanonicalOffloadArch(StringRef ArchStr) override {
27872787
CudaArch Arch = StringToCudaArch(ArchStr);
2788-
if (Arch == CudaArch::UNKNOWN) {
2788+
if (Arch == CudaArch::UNKNOWN || !IsNVIDIAGpuArch(Arch)) {
27892789
C.getDriver().Diag(clang::diag::err_drv_cuda_bad_gpu_arch) << ArchStr;
27902790
return StringRef();
27912791
}

clang/test/Driver/cuda-bad-arch.cu

+2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
// RUN: | FileCheck -check-prefix BAD %s
1111
// RUN: %clang -### -target x86_64-linux-gnu --cuda-gpu-arch=sm_19 -c %s 2>&1 \
1212
// RUN: | FileCheck -check-prefix BAD %s
13+
// RUN: %clang -### -target x86_64-linux-gnu --cuda-gpu-arch=gfx900 -c %s 2>&1 \
14+
// RUN: | FileCheck -check-prefix BAD %s
1315

1416
// BAD: error: Unsupported CUDA gpu architecture
1517

0 commit comments

Comments
 (0)