Skip to content

Commit da931ea

Browse files
committed
refactor: use enum
1 parent b3fdcce commit da931ea

File tree

3 files changed

+23
-28
lines changed

3 files changed

+23
-28
lines changed

packages/compiler-vapor/src/errors.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export function defaultOnWarn(msg: CompilerError) {
1010
__DEV__ && console.warn(`[Vue warn] ${msg.message}`)
1111
}
1212

13-
export const enum ErrorCodes {
13+
export enum ErrorCodes {
1414
// transform errors
1515
VAPOR_BIND_NO_EXPRESSION,
1616
VAPOR_ON_NO_EXPRESSION,

packages/compiler-vapor/src/ir.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { SourceLocation } from '@vue/compiler-dom'
22

3-
export const enum IRNodeTypes {
3+
export enum IRNodeTypes {
44
ROOT,
55
TEMPLATE_FACTORY,
66
FRAGMENT_FACTORY,

packages/compiler-vapor/src/transform.ts

+21-26
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
import type {
1+
import {
2+
type RootNode,
3+
type Node,
4+
type TemplateChildNode,
5+
type ElementNode,
6+
type AttributeNode,
7+
type InterpolationNode,
8+
type TransformOptions,
9+
type DirectiveNode,
10+
type ExpressionNode,
211
NodeTypes,
3-
RootNode,
4-
Node,
5-
TemplateChildNode,
6-
ElementNode,
7-
AttributeNode,
8-
InterpolationNode,
9-
TransformOptions,
10-
DirectiveNode,
11-
ExpressionNode,
1212
} from '@vue/compiler-dom'
1313
import {
1414
type OperationNode,
@@ -235,27 +235,27 @@ function transformChildren(
235235
const isLast = index === children.length - 1
236236

237237
switch (node.type) {
238-
case 1 satisfies NodeTypes.ELEMENT: {
238+
case NodeTypes.ELEMENT: {
239239
transformElement(child as TransformContext<ElementNode>)
240240
break
241241
}
242-
case 2 satisfies NodeTypes.TEXT: {
242+
case NodeTypes.TEXT: {
243243
child.template += node.content
244244
break
245245
}
246-
case 3 satisfies NodeTypes.COMMENT: {
246+
case NodeTypes.COMMENT: {
247247
child.template += `<!--${node.content}-->`
248248
break
249249
}
250-
case 5 satisfies NodeTypes.INTERPOLATION: {
250+
case NodeTypes.INTERPOLATION: {
251251
transformInterpolation(
252252
child as TransformContext<InterpolationNode>,
253253
isFirst,
254254
isLast,
255255
)
256256
break
257257
}
258-
case 12 satisfies NodeTypes.TEXT_CALL:
258+
case NodeTypes.TEXT_CALL:
259259
// never?
260260
break
261261
default: {
@@ -305,7 +305,7 @@ function transformInterpolation(
305305
) {
306306
const { node } = ctx
307307

308-
if (node.content.type === (8 satisfies NodeTypes.COMPOUND_EXPRESSION)) {
308+
if (node.content.type === NodeTypes.COMPOUND_EXPRESSION) {
309309
// TODO: CompoundExpressionNode: {{ count + 1 }}
310310
return
311311
}
@@ -345,7 +345,7 @@ function transformProp(
345345
): void {
346346
const { name } = node
347347

348-
if (node.type === (6 satisfies NodeTypes.ATTRIBUTE)) {
348+
if (node.type === NodeTypes.ATTRIBUTE) {
349349
if (node.value) {
350350
ctx.template += ` ${name}="${node.value.content}"`
351351
} else {
@@ -361,8 +361,7 @@ function transformProp(
361361
case 'bind': {
362362
if (
363363
!exp ||
364-
(exp.type === (4 satisfies NodeTypes.SIMPLE_EXPRESSION) &&
365-
!exp.content.trim())
364+
(exp.type === NodeTypes.SIMPLE_EXPRESSION && !exp.content.trim())
366365
) {
367366
ctx.options.onError!(
368367
createCompilerError(ErrorCodes.VAPOR_BIND_NO_EXPRESSION, loc),
@@ -377,9 +376,7 @@ function transformProp(
377376
} else if (!node.arg) {
378377
// TODO support v-bind="{}"
379378
return
380-
} else if (
381-
node.arg.type === (8 satisfies NodeTypes.COMPOUND_EXPRESSION)
382-
) {
379+
} else if (node.arg.type === NodeTypes.COMPOUND_EXPRESSION) {
383380
// TODO support :[foo]="bar"
384381
return
385382
}
@@ -404,9 +401,7 @@ function transformProp(
404401
if (!node.arg) {
405402
// TODO support v-on="{}"
406403
return
407-
} else if (
408-
node.arg.type === (8 satisfies NodeTypes.COMPOUND_EXPRESSION)
409-
) {
404+
} else if (node.arg.type === NodeTypes.COMPOUND_EXPRESSION) {
410405
// TODO support @[foo]="bar"
411406
return
412407
} else if (expr === null) {
@@ -461,7 +456,7 @@ function processExpression(
461456
expr: ExpressionNode | undefined,
462457
): string | null {
463458
if (!expr) return null
464-
if (expr.type === (8 satisfies NodeTypes.COMPOUND_EXPRESSION)) {
459+
if (expr.type === NodeTypes.COMPOUND_EXPRESSION) {
465460
// TODO
466461
return ''
467462
}

0 commit comments

Comments
 (0)