Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

fix(default-theme): srcset image display wrong incase url have space #1985

Merged

Conversation

quando1910
Copy link
Collaborator

@quando1910 quando1910 commented Mar 30, 2023

Changes

  • Add encodeURI to the url of srcset.

Before:
Screen Shot 2023-03-30 at 11 47 11 AM

After:
Screen Shot 2023-03-30 at 11 47 30 AM

Checklist

  • test srcset.

Sorry, something went wrong.

@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
shopware-pwa-docs ⬜️ Ignored (Inspect) Mar 30, 2023 at 4:51AM (UTC)

@quando1910 quando1910 requested a review from mkucmus March 30, 2023 04:59
@quando1910 quando1910 self-assigned this Mar 30, 2023
@quando1910 quando1910 requested a review from patzick March 30, 2023 05:00
@patzick patzick merged commit f7bad06 into master Mar 30, 2023
@patzick patzick deleted the fix/srcset-image-display-wrong-incase-url-have-space branch March 30, 2023 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants