options is required for 3.4.0

[crixusshen]

in the new 3.4.0,I found options of new BundleAnalyzerPlugin(options?: object) that it become required, otherwise it will get an error: Cannot use 'in' operator to search for 'analyzerPort' in undefined. if using the new BundleAnalyzerPlugin({}) in this way is successful.Is there a problem with 3.4.0？

[valscion]

Thanks, this seems like a regression caused by #290

We'll get a fix out shortly

[valscion]

Fixed in v3.4.1

[avin-kavish]

2 years working with javascript and never knew the in operator didn't work on undefined. All the tests passed too. Will passing nulls break it too, if so is that a case we need to accommodate?

[valscion]

Passing null as options has never been supported.

EDIT: Looks like {...null} does evaluate to an empty object. However, the documented API never mentioned that it would be OK to pass null to the constructor, so maybe checking null there would be unnecessary.

[th0r]

Passing null as options has never been supported.

Yes, we shouldn't cover this case - it's a user's responsibility to provide parameter with proper type.