Skip to content

Commit 3730467

Browse files
committed
[test] Do not call duplex.end() prematurely
Keep the `WebSocket` connection open while the test is run. Refs: nodejs/node#32780
1 parent 651d662 commit 3730467

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/create-websocket-stream.test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,7 @@ describe('createWebSocketStream', () => {
414414
ws._receiver.on('drain', () => {
415415
called.push('drain');
416416
assert.ok(!ws._socket.isPaused());
417+
duplex.end();
417418
});
418419

419420
const list = Sender.frame(randomBytes(16 * 1024), {
@@ -429,7 +430,6 @@ describe('createWebSocketStream', () => {
429430
ws._socket.push(Buffer.concat(list));
430431
});
431432

432-
duplex.on('resume', duplex.end);
433433
duplex.on('close', () => {
434434
assert.deepStrictEqual(called, ['read', 'drain']);
435435
wss.close(done);
@@ -450,6 +450,7 @@ describe('createWebSocketStream', () => {
450450
assert.ok(!ws._receiver._writableState.needDrain);
451451
read();
452452
assert.ok(!ws._socket.isPaused());
453+
duplex.end();
453454
};
454455

455456
ws.on('open', () => {
@@ -470,7 +471,6 @@ describe('createWebSocketStream', () => {
470471
ws._socket.push(Buffer.concat(list));
471472
});
472473

473-
duplex.on('resume', duplex.end);
474474
duplex.on('close', () => {
475475
assert.deepStrictEqual(called, ['drain', 'read']);
476476
wss.close(done);

0 commit comments

Comments
 (0)