Move +classNameWithoutNamespaces to WordPressSharedObjC (#24164)

* Move `NSObject +classNameWithoutNamespaces` to WordPressSharedObjC

So we can use it next in WordPressData.

* Make WordPressData depend on WordPressSharedObjC

Author: mokagio

Modules/Package.swift

@@ -65,7 +65,13 @@ let package = Package(
             .product(name: "XCUITestHelpers", package: "ScreenObject"),
         ], swiftSettings: [.swiftLanguageMode(.v5)]),
         .target(name: "WordPressDataObjC"),
-        .target(name: "WordPressData", dependencies: [.target(name: "WordPressDataObjC")]),
+        .target(
+            name: "WordPressData",
+            dependencies: [
+                .target(name: "WordPressDataObjC"),
+                .target(name: "WordPressSharedObjC")
+            ]
+        ),
         .target(name: "WordPressFlux", swiftSettings: [.swiftLanguageMode(.v5)]),
         .target(name: "WordPressCore", dependencies: [.target(name: "WordPressShared"), .product(name: "WordPressAPI", package: "wordpress-rs")]),
         .target(name: "WordPressSharedObjC", resources: [.process("Resources")], swiftSettings: [.swiftLanguageMode(.v5)]),

Modules/Sources/WordPressSharedObjC/Utility/NSObject+ClassName.m

@@ -0,0 +1,11 @@
+#import "NSObject+ClassName.h"
+
+@implementation NSObject (ClassName)
+
++ (NSString *)classNameWithoutNamespaces
+{
+    // Note that Swift prepends the module name to the class name itself
+    return [[NSStringFromClass(self) componentsSeparatedByString:@"."] lastObject];
+}
+
+@end

Modules/Sources/WordPressSharedObjC/include/NSObject+ClassName.h

@@ -0,0 +1,11 @@
+#import <Foundation/Foundation.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+@interface NSObject (ClassName)
+
++ (NSString *)classNameWithoutNamespaces;
+
+@end
+
+NS_ASSUME_NONNULL_END

WordPress/Classes/Categories/NSObject+Helpers.h

@@ -4,6 +4,10 @@ NS_ASSUME_NONNULL_BEGIN
 
 @interface NSObject (Helpers)
 
+// FIXME: Currently duplicated in WordPressSharedObjC because it'll be used in WordPressData (which depends on WordPressSharedObjc)
+// It's not convenient to replace all usages in the main targets at this time.
+// They should progressively diminish as we move all the Core Data related code into WordPressData.
+// At that point, we should be able to remove this method from the main target.
 + (NSString *)classNameWithoutNamespaces;
 
 - (void)debounce:(SEL)selector afterDelay:(NSTimeInterval)timeInterval;