Skip to content

Commit a057c0a

Browse files
committed
Remove lto from the release profile
The performance difference has shrunk substantially adding inline to a bunch of functions. The performance difference with or without lto is about 4 seconds on the slowest clip/qp on a standard awcy run (MINECRAFT, objective-1-fast, qp 80). The compile time difference is 42 seconds. If it's possible to have good performance with lto off, then optimizing without it will provide a good development profile. Going forward, it would be advisable to use lto to check for performancem problems. It may be possible to create a seperate profile between dev and release. Would require rust-lang/cargo#6988 and AWCY would need to be modified to use the new profile/still work with old versions of rav1e.
1 parent 0680e52 commit a057c0a

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

Cargo.toml

-2
Original file line numberDiff line numberDiff line change
@@ -149,11 +149,9 @@ debug = true
149149
codegen-units = 1 # if > 1 enables parallel code generation which improves
150150
# compile times, but prevents some optimizations.
151151
# Passes `-C codegen-units`. Ignored when `lto = true`.
152-
lto = true
153152

154153
[profile.bench]
155154
codegen-units = 1
156-
lto = true
157155

158156
[workspace]
159157
members = [".", "ivf", "rav1e_js", "v_frame"]

0 commit comments

Comments
 (0)