Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72-column wrapping in git commit mode #1068

Open
chris-martin opened this issue Mar 2, 2018 · 3 comments
Open

72-column wrapping in git commit mode #1068

chris-martin opened this issue Mar 2, 2018 · 3 comments

Comments

@chris-martin
Copy link

It seems the standard max line length for git commits is 72 characters. gitCommitMode is currently using the standard modePrettify which wraps at column 80. Does it make sense to change this in yi?

@noughtmare
Copy link
Member

I think it would be nice to at least have the 80 column paragraph width be configurable. But I personally don't use this feature very much, so I probably won't work on this anytime soon.

@chris-martin
Copy link
Author

chris-martin commented Mar 4, 2018

Would it make sense to add a field modePreferredLineLength :: Maybe Int (where Nothing means use some global default) to the Mode type, and then alter the modePrettify implementations for the various modes that ought to respect that setting?

@noughtmare
Copy link
Member

I've just opened #1069 to track how the current configuration system can be improved.

For the time being, I think a modePreferredLineLength is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants