Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't adjust edgeOffset #11

Closed
eddts opened this issue May 3, 2016 · 3 comments
Closed

Can't adjust edgeOffset #11

eddts opened this issue May 3, 2016 · 3 comments
Assignees

Comments

@eddts
Copy link

eddts commented May 3, 2016

Thanks for the library, just what i needed, but...

if (!edgeOffset || edgeOffset !== 0) { // When scrolling, this amount of distance is kept from the edges of the scrollContainer: edgeOffset = 9 //px }

... If edgeOffset is false (0, null, undefined), or it's not exactly 0...

That conditional can never fail, so it always set's the offset to 9px!

@zengabor
Copy link
Owner

zengabor commented May 3, 2016

Oops, that should be obviously &&

Sorry about that. Will release a fix soon.

@zengabor zengabor self-assigned this May 3, 2016
@zengabor
Copy link
Owner

zengabor commented May 5, 2016

Hi @eddts, this is now fixed in 3.0.2

@eddts
Copy link
Author

eddts commented May 6, 2016

Brilliant, thanks again for library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants