Validation_For_Create_DTOs #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirazyzz
requested changes
Oct 5, 2024
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Bogus" Version="35.6.1" /> | |||
| <PackageReference Include="FluentValidation.AspNetCore" Version="11.3.0" /> | |||
There was a problem hiding this comment.
it should be in application layer
There was a problem hiding this comment.
Validators should be configured in Application Layer
| @@ -1,4 +1,5 @@ | |||
| using CheckDrive.Api.Extensions; | |||
| using FluentValidation.AspNetCore; | |||
| @@ -12,7 +13,7 @@ | |||
|
|
|||
| var builder = WebApplication.CreateBuilder(args); | |||
|
|
|||
| builder.Host.UseSerilog(); | |||
| builder.Host.UseSerilog(); | |||
| @@ -4,6 +4,7 @@ namespace CheckDrive.Application.DTOs.DispatcherReview; | |||
|
|
|||
| public sealed record CreateDispatcherReviewDto( | |||
| int CheckPointId, | |||
| int DriverId, | |||
There was a problem hiding this comment.
CheckPointid should be enough, because CheckPoint.DoctorReview already contains DriverId we can take from there.
Comment on lines
+9
to
+10
| RuleFor(x => x.DriverId) | ||
| .GreaterThan(0).WithMessage("Haydovchini tanlashingiz shart."); |
There was a problem hiding this comment.
do we need to check for DoctorId?
| @@ -24,6 +24,7 @@ | |||
| <PackageReference Include="FluentEmail.Core" Version="3.0.2" /> | |||
| <PackageReference Include="FluentEmail.MailKit" Version="3.0.2" /> | |||
| <PackageReference Include="FluentEmail.Razor" Version="3.0.2" /> | |||
| <PackageReference Include="FluentValidation.AspNetCore" Version="11.3.0" /> | |||
There was a problem hiding this comment.
does his layer need this package?
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Bogus" Version="35.6.1" /> | |||
| <PackageReference Include="FluentValidation.AspNetCore" Version="11.3.0" /> | |||
There was a problem hiding this comment.
does his layer need this package?
| @@ -17,6 +17,7 @@ | |||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | |||
| </PackageReference> | |||
| <PackageReference Include="FluentAssertions" Version="6.12.1" /> | |||
| <PackageReference Include="FluentValidation.AspNetCore" Version="11.3.0" /> | |||
There was a problem hiding this comment.
does his layer need this package?
| @@ -15,6 +15,7 @@ | |||
| <PackageReference Include="AutoFixture.Idioms" Version="4.18.1" /> | |||
| <PackageReference Include="coverlet.collector" Version="6.0.0" /> | |||
| <PackageReference Include="FluentAssertions" Version="6.12.1" /> | |||
| <PackageReference Include="FluentValidation.AspNetCore" Version="11.3.0" /> | |||
There was a problem hiding this comment.
does his layer need this package?
aXayitov
approved these changes
Oct 16, 2024
Comment on lines
+4
to
+5
| namespace CheckDrive.Application.Validators; | ||
| public class CreateDispatcherReviewDtoValidator : AbstractValidator<CreateDispatcherReviewDto> |
Comment on lines
+4
to
+5
| namespace CheckDrive.Application.Validators; | ||
| public class CreateDoctorReviewDtoValidator : AbstractValidator<CreateDoctorReviewDto> |
There was a problem hiding this comment.
there must be a space here as well
Comment on lines
+4
to
+5
| namespace CheckDrive.Application.Validators; | ||
| public class CreateMechanicAcceptanceReviewDtoValidator : AbstractValidator<CreateMechanicAcceptanceReviewDto> |
|
change target branch from master to integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.