233 added Email and Sms services #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added error message and set changed to init for code security
aXayitov
changed the title
aXayitov
changed the title
Mirazyzz
requested changes
Oct 5, 2024
There was a problem hiding this comment.
don't push configuration values
| public string UserName { get; init; } | ||
| public string PhoneNumber { get; init; } | ||
| public string? Subject { get; init; } | ||
| public string? Code { get; init; } = "12345"; |
There was a problem hiding this comment.
should this message be sent by default?
Comment on lines
7
to
8
| namespace CheckDrive.Domain.Enums; | ||
| public enum SmsType |
| public enum SmsType | ||
| { | ||
| ForgotPassword, | ||
| MessageType |
| @@ -35,6 +32,7 @@ | |||
| <PackageReference Include="Serilog" Version="3.1.1" /> | |||
| <PackageReference Include="Serilog.AspNetCore" Version="8.0.1" /> | |||
| <PackageReference Include="Serilog.Sinks.Console" Version="5.0.1" /> | |||
| <PackageReference Include="Twilio" Version="7.4.0" /> | |||
Comment on lines
4
to
5
| namespace CheckDrive.Infrastructure.Sms.Factories; | ||
| internal interface ISmsMetadataFactory |
There was a problem hiding this comment.
separate with an empty line
Comment on lines
4
to
5
| namespace CheckDrive.Infrastructure.Sms.Factories; | ||
| internal class SmsMetadataFactory : ISmsMetadataFactory |
Comment on lines
11
to
12
| }; | ||
| public SmsMetadata Create( |
| { | ||
| private readonly Dictionary<SmsType, string> smsSubjects = new() | ||
| { | ||
| { SmsType.MessageType, "Message" }, |
Comment on lines
35
to
36
| // var template = GetTemplate(metadata.SmsType); | ||
| // var messageContent = await BuildMessageContent(template, metadata); |
weekly-master-update
Update EmailConfiguration.cs
Migration history were not created properly needed to recreate history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.