This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Perform maintenance on the unit tests project #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use [CallerFilePath] in order to get the path to the test documents, making it unnecessary to copy the files from the `documents` directory to the output directory. Also disable deterministic source paths so that the caller file path is never substituted with /_/ in case `ContinuousIntegrationBuild` is enabled.
Microsoft.AspNetCore.WebUtilities 2.2.0 is used on all target frameworks so the conditions were unnecessary.
Adapt the tests for FluentAssertions 6 breaking changes.
Remove conditional compilation around osx-arm64 which was introduced in DuendeArchive#428 but is not necessary anymore now that the library is targeting .NET 6 onwards. Also avoid duplicating the .NET target framework but add net462 and net472 when running on Windows (on both the main and unit tests projects).
The `Should().BeEquivalentTo()` versions are much easier to read, actually test all the properties and in case of failure the error messages are excellent.
damianh
approved these changes
Oct 4, 2024
|
Looks good to me. Thanks for the contribution @0xced! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft.Extensions.PlatformAbstractionand use [CallerFilePath] in order to get the path to the test documents, making it unnecessary to copy the files from thedocumentsdirectory to the output directory.Microsoft.AspNetCore.WebUtilities(it was unnecessary)Also avoid duplicating the .NET target framework but add
net462andnet472when running on Windows (on both the main and unit tests projects).