Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern Ore Textures #4085

Merged
merged 10 commits into from
Mar 22, 2025
Merged

Conversation

jude123412
Copy link
Contributor

@jude123412 jude123412 commented Mar 20, 2025

After the addition of Raw Ores to GT5 I felt like the Ore Textures needed a bit of modernization. Especially since there are many different Texture Sets so I have created some new ones that are based on the 1.20.1 ore textures. I have also made all the small ores somewhat resemble there main ore counter part.
Before
2025-03-20_16 10 24
2025-03-20_16 12 10

After
2025-03-20_19 41 56
2025-03-20_19 29 06

I have included a Resource Pack to revert these changes for those who don't like the new textures
Old-School-Ores.zip

@jude123412 jude123412 changed the title Modern ore textures Modern Ore Textures Mar 20, 2025
Copy link
Member

@Dream-Master Dream-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we not change 16x16 to 32x32 texture. Why we not use it as ressourcepack so people can decided if they want to change texture or not. We loosing a bit profile be a 1.7.10 pack?

@jude123412
Copy link
Contributor Author

Thats fair, Ill change the textures for Infused ores to be 16x16 not 32x32 :)

@YannickMG
Copy link
Contributor

I love all those changes. As mentioned as long as they are 16x16 I hope we can get those in the base pack.

@GDCloudstrike
Copy link
Member

imo changes like this fall under the 'major style change' category and are more suited for texturepacks rather than replacing main pack ones, especially since this affects all ores

@FourIsTheNumber
Copy link
Contributor

Changing textures in main pack is fine 🤷
If they fit the style and the resolution I don't see why we have to defend the sanctity of 10 year old autogen programmer art

@YannickMG
Copy link
Contributor

imo changes like this fall under the 'major style change' category and are more suited for texturepacks rather than replacing main pack ones, especially since this affects all ores

If we can change wafers and circuit parts (and they look great now), there's no reason we can't improve other areas of the pack's aesthetics. This change here is unambiguously a pure improvement.

@Ruling-0
Copy link
Contributor

I think reworking the small ore textures is a fantastic idea - the gradient felt pretty ugly. For the main ores some of the examples do feel like a divergence better left to resource packs.

One example that stands out is what I think is redstone above. IMO this tiles worse and is very loud where most ore textures are (and imo better as) more subtle.

@FourIsTheNumber FourIsTheNumber added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Mar 20, 2025

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
…T5-Unofficial into modern-ore-textures
@Persus1
Copy link

Persus1 commented Mar 20, 2025

I think this quite a major change when it comes to the look of this modpack and im personally very oldschool when it come to changed textures. If changes like this get added would it be atleast possible to add a resourcepack to the pack to easily revert major changes?

@jude123412
Copy link
Contributor Author

I could create a resource pack to revert these changes

@jude123412
Copy link
Contributor Author

jude123412 commented Mar 20, 2025

I think these look a bit better than before :)
Honestly the old Infused ores do look better than the animated one.
2025-03-20_19 29 06
2025-03-20_19 41 56

@YannickMG
Copy link
Contributor

Personally I really missed the animated infused ore texture, but it might be a pain to make them work in 16x16.

@jude123412
Copy link
Contributor Author

jude123412 commented Mar 20, 2025

it is a bit :D I tried twice and didn't like either result

@Dream-Master
Copy link
Member

the thaumcraft textures was 32x32 ? and animated ?

@EnderProyects
Copy link
Contributor

The "vanilla" thaum texture is animated, at least Iremember it like that

@jude123412
Copy link
Contributor Author

I have just included a resource pack to revert these texture changes ;)

@jude123412 jude123412 requested a review from Dream-Master March 20, 2025 20:03
@Dream-Master Dream-Master requested a review from a team March 20, 2025 20:17
@Dream-Master Dream-Master dismissed their stale review March 20, 2025 20:18

32 texture was reverted

Copy link
Contributor

@YannickMG YannickMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, improves the overall readability of ores in the pack and general sentiment I've seen is mostly positive.

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Mar 21, 2025

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
@Caedis
Copy link
Member

Caedis commented Mar 21, 2025

@jude123412 the resource pack can be added to https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/tree/master/resourcepacks
Can name it something like Legacy Ore Textures

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
@Dream-Master
Copy link
Member

i like the new textures. cheked a bit ingame

jude123412 and others added 2 commits March 22, 2025 09:23

Verified

This commit was created on github.com and signed with GitHub’s verified signature.

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
@Dream-Master Dream-Master enabled auto-merge (squash) March 22, 2025 11:48
@Dream-Master Dream-Master merged commit 1735e43 into GTNewHorizons:master Mar 22, 2025
5 checks passed
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants