Fixing vampirism degrading nutrition #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesCook
reviewed
Apr 10, 2024
src/main/java/ca/wescook/nutrition/modules/witchery/events/WitcheryEventHandler.java
Outdated
Show resolved
Hide resolved
|
apparently the server really doesn't like loading an empty init |
|
wholesome 100 |
Alastors
changed the title
mitchej123
reviewed
Apr 10, 2024
mitchej123
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being a vampire causes a bug with nutrition since vampirism apparently refills the hunger bar, leading to a degradation of the nutrition bars.
What this attempts to do (successfully according to Xabe in tests) is set a hard floor for vampire's nutritional bars (50%) adding a method to do so automagically that could be utilized in other methods similar to this in the future.
How this achieves it is by modifying the nutritional manager class and adding the method mentioned above, and then adding a witchery module folder containing a listener that calls this method if the player is a vampire which briefly checks if any of the player's nutritional bars are below 50, and if they are, sets them to 50.
And yes, I made sure it's an optional dep, I added the usual interface and class I use to manage that for ease in the future, given i'm sure this'll pop up again, might need to add Thaumic Horizons compat as well since it has similar features.
fixes: GTNewHorizons/GT-New-Horizons-Modpack#14771