Fix nutrients always stuck at 50% in singleplayer #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
No matter which combination of foods you eat, in Single Player nutrition always converges at 50%.
This does not happen on a dedicated Server, only in Single Player.
Steps to reproduce
Set any nutrition to below 50%, for example dairy
/nutrition set YourName dairy 0Then eat something that does not have dairy, for example a blueberry smoothie.
/hunger 1, then eat it.Open nutritions panel, dairy increased to 1%
Its the same with all other foods/nutrients. It also decreases any nutrients that are above 50 back down to 50.
Version
GTNH 2.6.1
Java 17.0.12+7
Nutrition 0.0.10
Fix
I've dug around the codebase a bit and traced it to this PR #5
The comment at https://github.com/GTNewHorizons/Nutrition/blob/master/src/main/java/ca/wescook/nutrition/events/EventEatFood.java#L20 explains how and when nutrients are supposed to normalize to 50.
The bug is caused by a check that is supposed to distinguish between client and server, but in singleplayer it's never detecting the client. I replaced it with the same check that the other event also uses.
I've tested the change in both singleplayer and multiplayer, and this fixes it.
Also tested that healing axe still normalizes the nutrients.