Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit 93da30d

Browse files
rafbgarciabekos
authored andcommitted
fix(datepicker): rename dateFormat to datepickerPopup in datepickerPopupConfig
Closes #1810
1 parent 467dd15 commit 93da30d

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

src/datepicker/datepicker.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ angular.module('ui.bootstrap.datepicker', ['ui.bootstrap.position'])
296296
})
297297

298298
.constant('datepickerPopupConfig', {
299-
dateFormat: 'yyyy-MM-dd',
299+
datepickerPopup: 'yyyy-MM-dd',
300300
currentText: 'Today',
301301
clearText: 'Clear',
302302
closeText: 'Done',
@@ -328,7 +328,7 @@ function ($compile, $parse, $document, $position, dateFilter, datepickerPopupCon
328328
};
329329

330330
attrs.$observe('datepickerPopup', function(value) {
331-
dateFormat = value || datepickerPopupConfig.dateFormat;
331+
dateFormat = value || datepickerPopupConfig.datepickerPopup;
332332
ngModel.$render();
333333
});
334334

src/datepicker/test/datepicker.spec.js

+20
Original file line numberDiff line numberDiff line change
@@ -795,6 +795,26 @@ describe('datepicker directive', function () {
795795

796796
});
797797

798+
describe('setting datepickerPopupConfig', function() {
799+
var originalConfig = {};
800+
beforeEach(inject(function(datepickerPopupConfig) {
801+
angular.extend(originalConfig, datepickerPopupConfig);
802+
datepickerPopupConfig.datepickerPopup = 'MM-dd-yyyy';
803+
804+
element = $compile('<input ng-model="date" datepicker-popup>')($rootScope);
805+
$rootScope.$digest();
806+
}));
807+
afterEach(inject(function(datepickerPopupConfig) {
808+
// return it to the original state
809+
angular.extend(datepickerPopupConfig, originalConfig);
810+
}));
811+
812+
it('changes date format', function() {
813+
expect(element.val()).toEqual('09-30-2010');
814+
});
815+
816+
});
817+
798818
describe('as popup', function () {
799819
var inputEl, dropdownEl, changeInputValueTo, $document;
800820

0 commit comments

Comments
 (0)