Fixed wrong param name dateFormat in datepickerPopupConfig

[rafbgarcia]

Here it is

[Foxandxss]

When submitting a PR you need to update (or add if needed) the tests and then run karma to check that everything is ok. The build did break.

[rafbgarcia]

Sorry, I was doing something else and didn't realize that.

Done :-)

[bekos]

@rafbgarcia Seems that a test is missing for this config . Can you add one? It shouldn't be much trouble.

[rafbgarcia]

I think it's ok now.

[bekos]

@rafbgarcia I don't think this is the correct test. What you test is already tested in the 'custom format' describe block.

You should add a test in the 'setting datepickerConfig', by doing datepickerConfig.datepickerPopup= '...'; Does this makes sense?

[rafbgarcia]

@bekos I'm now giving full attention to it.
I read the code and in my understanding the this param is only available in datepickerPopup, right?
I can't find the tests to the constant datepickerPopupConfig, there is a test 'as popup' which also doesn't test it.
Should we add tests to it or there is a reason why this is not being tested?

[bekos]

@rafbgarcia Oops, my mistake. You are right, we are missing tests for the datepickerPopupConfig. Can you add them in a similar way that datepickerConfig is tested?

[rafbgarcia]

@bekos what do you think now?

[bekos]

@rafbgarcia Nice 👍