Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero width of first spacer columns in case multiple such colums are present #5454

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

felixfontein
Copy link
Contributor

It seems that #5417 was not sufficient in some cases.

  1. default_gateway in https://galaxy.ansible.com/ui/repo/published/community/vmware/content/module/vmware_vmkernel/?version=5.4.0 is now correctly indented.
  2. authorizations in https://galaxy.ansible.com/ui/repo/published/community/crypto/content/module/acme_account_info/#return-values is not correctly indented (but note that its field identifiers is indented).

For me, adding an additional min-width: 20px to .spacer fixed the problem. I've tested this both with current Firefox and Chromium.

…re present.

No-Issue
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Copy link
Contributor Author

CC @himdel @prat98

@prat98
Copy link
Collaborator

prat98 commented Mar 4, 2025

Screenshot 2025-03-04 at 3 48 01 PM

Need to fix a small linting error here before we can merge, looks good otherwise :)

@prat98
Copy link
Collaborator

prat98 commented Mar 5, 2025

All relevant checks passing LGTM! 🚀

@prat98 prat98 self-requested a review March 5, 2025 14:33
Copy link
Collaborator

@prat98 prat98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All relevant checks passing LGTM! 🚀

@prat98 prat98 merged commit 3de18f5 into ansible:master Mar 5, 2025
13 of 14 checks passed
@felixfontein felixfontein deleted the zero-width-2 branch March 5, 2025 18:41
@felixfontein
Copy link
Contributor Author

@prat98 thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants