feat: Add support for excluded_attributes in JSON source hierarchy #953
Conversation
swngarg-lt
changed the title
|
|
WebDriverAgentTests/IntegrationTests/XCUIApplicationHelperTests.m
Outdated
Show resolved
Hide resolved
WebDriverAgentTests/IntegrationTests/XCUIApplicationHelperTests.m
Outdated
Show resolved
Hide resolved
| @@ -379,7 +409,7 @@ - (BOOL)fb_dismissKeyboardWithKeyNames:(nullable NSArray<NSString *> *)keyNames | |||
| id extractedElement = extractIssueProperty(issue, @"element"); | |||
|
|
|||
| id<FBXCElementSnapshot> elementSnapshot = [extractedElement fb_takeSnapshot]; | |||
| NSDictionary *elementAttributes = elementSnapshot ? [self.class dictionaryForElement:elementSnapshot recursive:NO] : @{}; | |||
| NSDictionary *elementAttributes = elementSnapshot ? [self.class dictionaryForElement:elementSnapshot recursive:NO excludedAttributes:nil] : @{}; | |||
There was a problem hiding this comment.
Please reformat this ternary operator same way it was done below for excludedAttributes
|
@mykola-mokhnach addressed the comments in latest fix. Still workflow is failing due to xcode developer path issue. Can you help? Error in failed workflows : |
WebDriverAgentTests/IntegrationTests/XCUIApplicationHelperTests.m
Outdated
Show resolved
Hide resolved
This looks like Azure CI issue. Please ignore it for now |
Ok. Functional Tests are failing, one of the reason, it couldn't find xcode version on CI. another is a 5 min timeout issue and it seems Simulator couldn't start within 5 min. |
These are also issues related to the CI slowness. Unfortunately we cannot address them now because of a known WDIO issue. See webdriverio/webdriverio#13778 for more details. |
## [8.11.0](v8.10.1...v8.11.0) (2024-11-11) ### Features * Add support for excluded_attributes in JSON source hierarchy ([#953](#953)) ([6112223](6112223))
|
🎉 This PR is included in version 8.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This issue should be resolved now. |
No description provided.