fix: re-use parent's accessibility property #967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swngarg-lt
changed the title
| @@ -196,7 +199,24 @@ + (NSDictionary *)dictionaryForElement:(id<FBXCElementSnapshot>)snapshot | |||
| return [@([wrappedSnapshot isWDVisible]) stringValue]; | |||
| }, | |||
| @"accessible": ^{ | |||
| return [@([wrappedSnapshot isWDAccessible]) stringValue]; | |||
| if (parentAccessible) { | |||
There was a problem hiding this comment.
I am not quite convinced about this change, because:
- It breaks the backward compatiblity
- It does not properly calculate the accessibility value for tree elements
- It causes unnecessary code duplication
|
@swngarg-lt I have created #968 The change there is breaking, but it only affects debug into of an accessibility audit element. Most likely it would also require a major version bump. Nevertheless please check if it solves your original problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: only for source api (with useJSONSource)