Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add timeout option to adb.pull() in stopRecordingScreen function #921

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

didental
Copy link
Contributor

There was set not enough long timeout: 1-min (default value)

Copy link

linux-foundation-easycla bot commented Feb 21, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@mykola-mokhnach
Copy link
Contributor

Please update the PR title according to https://www.conventionalcommits.org/en/v1.0.0/ standard

@didental didental changed the title Set the adb pulling timeout value as 5-min feat: Add timeout option to adb.pull() in stopRecordingScreen function Feb 22, 2024
@mykola-mokhnach mykola-mokhnach changed the title feat: Add timeout option to adb.pull() in stopRecordingScreen function chore: Add timeout option to adb.pull() in stopRecordingScreen function Feb 22, 2024
@mykola-mokhnach mykola-mokhnach merged commit e8539dc into appium:master Feb 22, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 22, 2024
## [9.0.1](v9.0.0...v9.0.1) (2024-02-22)

### Miscellaneous Chores

* Add timeout option to adb.pull() in stopRecordingScreen function ([#921](#921)) ([e8539dc](e8539dc))
Copy link

🎉 This PR is included in version 9.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants