Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete screen recording after serving. #300

Conversation

kkb912002
Copy link

It seems that the video file deletion was missed when the screen recording was properly terminated.

@mykola-mokhnach
Copy link

The driver is configured to cleanup the recorded video upon stopping the session:

await this._screenRecorder?.stop(true);

The recorded file is kept for the duration of the session, so one could download it repeatedly if necessary

@kkb912002
Copy link
Author

The driver is configured to cleanup the recorded video upon stopping the session:

await this._screenRecorder?.stop(true);

The recorded file is kept for the duration of the session, so one could download it repeatedly if necessary

Ah, to be precise, when recording screen multiple times with interruptions, only the last recorded file gets deleted, while the previously recorded files all remain in the temporary directory.

@kkb912002
Copy link
Author

delete it only when start new recording: #302

@kkb912002 kkb912002 closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants