feat: Add StorageClient #2275
Merged
feat: Add StorageClient #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
requested review from
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
KazuCocoa
reviewed
Mar 10, 2025
| var wsInfo = (Map<String, Object>) value.get("ws"); | ||
| var streamWsPathname = (String) wsInfo.get("stream"); | ||
| var eventWsPathname = (String) wsInfo.get("events"); | ||
| final var completion = new CountDownLatch(1); |
There was a problem hiding this comment.
Could CompletableFuture be good for modern Java instead of CountDownLatch? I don't have much experience this in Java, but I saw CompletableFuture usage for async before. (entire implementation itself looks good to me)
There was a problem hiding this comment.
I would say everything is good that does its job well, and is not deprecated, and is readable :)
The concept of CompletableFuture does not make java code async, it just hides the threading complexity under another abstraction layer.
If you have a proposal on how to make the same implementation shorter/better understable via CompletableFuture use then I would be happy to apply it
saikrishna321
approved these changes
Mar 10, 2025
valfirst
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Java client for the storage-plugin
Types of changes