Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AIP move "failed" variable a constant #1153

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

djjuhasz
Copy link
Collaborator

No description provided.

@djjuhasz djjuhasz force-pushed the dev/remove-extra-assignment branch from 39de35f to d80187d Compare March 13, 2025 16:42
@djjuhasz djjuhasz changed the title Remove unnecessary variable assigment Remove unnecessary variable assignment Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (4de3cc2) to head (10ac81e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
- Coverage   55.22%   55.18%   -0.04%     
==========================================
  Files         103      103              
  Lines        7709     7709              
==========================================
- Hits         4257     4254       -3     
- Misses       3179     3182       +3     
  Partials      273      273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@djjuhasz djjuhasz requested a review from jraddaoui March 13, 2025 16:51
@djjuhasz djjuhasz force-pushed the dev/remove-extra-assignment branch from d80187d to ed8e9b9 Compare March 14, 2025 00:59
@djjuhasz djjuhasz force-pushed the dev/remove-extra-assignment branch from ed8e9b9 to 10ac81e Compare March 14, 2025 02:22
@djjuhasz djjuhasz changed the title Remove unnecessary variable assignment Make AIP move "failed" variable a constant Mar 14, 2025
Copy link
Collaborator

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@djjuhasz djjuhasz merged commit 3bb44b1 into main Mar 24, 2025
14 checks passed
@djjuhasz djjuhasz deleted the dev/remove-extra-assignment branch March 24, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants