Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

337 update icdb #339

Closed
wants to merge 6 commits into from
Closed

337 update icdb #339

wants to merge 6 commits into from

Conversation

Voxanimus
Copy link
Collaborator

@Voxanimus Voxanimus commented Dec 7, 2022

Remove speaker and guest, keep thumnail format.
Update texte accordingly to the current year

close #337

Voxanimus and others added 4 commits December 4, 2022 19:08
update date, logos and text. change 2022 to 2023,
replace 20th aniversary logo by faculty logo and remove 20th anniversary mention in introduction text.
@Voxanimus Voxanimus self-assigned this Dec 7, 2022
@Voxanimus Voxanimus linked an issue Dec 7, 2022 that may be closed by this pull request
@Robb-Fr
Copy link
Collaborator

Robb-Fr commented Dec 14, 2022

@s314cy @dialexo don't remember, is it safe to merge a new package-lock.json ?

@s314cy
Copy link
Contributor

s314cy commented Dec 14, 2022

@s314cy @dialexo don't remember, is it safe to merge a new package-lock.json ?

ça dépend de la méta, généralement tu veux merge si tu as vérifié que tout fonctionne, que y a pas eu de changements shady du package.json et que le repo n'a pas gitignore le package-lock.json

le package-lock sert à ce que la CI et les devs puissent reproduire le state de la main branch (qui est fonctionnelle) avec tous les paquets à la bonne version

ça veut aussi dire que ça peut tout casser de merge un nouveau package-lock ^^

@codeofmochi
Copy link
Collaborator

codeofmochi commented Dec 14, 2022

@s314cy @dialexo don't remember, is it safe to merge a new package-lock.json ?

ça dépend de la méta, généralement tu veux merge si tu as vérifié que tout fonctionne, que y a pas eu de changements shady du package.json et que le repo n'a pas gitignore le package-lock.json

Yes, also note that the package-lock.json should definitely be commited (https://docs.npmjs.com/cli/v6/configuring-npm/package-locks#using-locked-packages). If you gitignore it and don't pin the versions (which is the case by default with npm and yarn), you're vulnerable to packages that don't follow semver, supply-chain attacks, etc.

le package-lock sert à ce que la CI et les devs puissent reproduire le state de la main branch (qui est fonctionnelle) avec tous les paquets à la bonne version

Not only CI and dev, but prod also, as it ensures that the dependency tree remains immutable in the whole pipeline.

ça veut aussi dire que ça peut tout casser de merge un nouveau package-lock ^^

In general yes. Though by default npm / yarn will only update if there are no breaking changes (e.g. ^1.0.1 may get updated to 1.2.5 for example), again assuming that the relevant package is following semver, which is not guaranteed. Usually, most packages follow semver and stuff doesn't break when running npm / yarn install and updating the package-lock.json.

So in the best case, we can automate dependency bumps with e.g. renovatebot, but this is only a good idea if the code is properly CI'd and tested, so that code paths that are affected by such changes are properly checked.

Copy link
Collaborator

@Robb-Fr Robb-Fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture d’écran 2022-12-19 à 17 28 00

Could we maybe re-put placeholders images and reduce the number of empty cells, keeping one raw of alumni etc ? This looks buggy for external viewer

@Voxanimus
Copy link
Collaborator Author

Could we maybe re-put placeholders images and reduce the number of empty cells, keeping one raw of alumni etc ? This looks buggy for external viewer

@DeepGreen1 has already done some commit about this view of the page. This is one of the reason why I hesitated to just close this PR and made change in a another one.

@Robb-Fr
Copy link
Collaborator

Robb-Fr commented Dec 19, 2022

Yep ok for me, let's do this, do I destroy this PR?

@Voxanimus
Copy link
Collaborator Author

Voxanimus commented Dec 19, 2022

Yep ok for me, let's do this, do I destroy this PR?

I think it would be easier and anyway we can just link again the issue with the new PR since there is still some modification to do.

Copy link
Collaborator

@NoeTerrier NoeTerrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super

@Robb-Fr Robb-Fr closed this Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ICBD page
5 participants