Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add og properties for preview #55

Merged
merged 3 commits into from
Jun 6, 2024
Merged

feat: add og properties for preview #55

merged 3 commits into from
Jun 6, 2024

Conversation

Thechi2000
Copy link
Contributor

Add OpenGraph properties to the TabTitle components to enable a preview in many social medias (see #54). Currently, the news and commissions pages have no image nor descriptions, since there currently is no adequate content on Directus, and I didn't feel like adding some solely for this feature.

I did not find a way to accurately test this feature, since it requires to go through a external tool like Telegram, which probably caches the results on its server side, and obviously cannot access the development server on localhost.

Closes #54.

Verified

This commit was signed with the committer’s verified signature.
nikclayton Nik Clayton

Verified

This commit was signed with the committer’s verified signature.
nikclayton Nik Clayton
@Thechi2000 Thechi2000 added the feature New feature or request label Jun 4, 2024
@Thechi2000 Thechi2000 self-assigned this Jun 4, 2024
@Thechi2000 Thechi2000 linked an issue Jun 4, 2024 that may be closed by this pull request
@Thechi2000 Thechi2000 changed the title 54 add preview feat: add og properties for preview Jun 4, 2024
@Thechi2000 Thechi2000 merged commit e0b698e into main Jun 6, 2024
4 of 5 checks passed
@Thechi2000 Thechi2000 deleted the 54-add-preview branch June 6, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add preview
2 participants