Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 76 subsonic page #79

Merged
merged 4 commits into from
Nov 3, 2024
Merged

feat: 76 subsonic page #79

merged 4 commits into from
Nov 3, 2024

Conversation

NoeTerrier
Copy link
Contributor

Close #76

Add subsonic page, with artists, plan, sponsors and description.

@NoeTerrier NoeTerrier added the feature New feature or request label Oct 29, 2024
@NoeTerrier NoeTerrier self-assigned this Oct 29, 2024
@NoeTerrier NoeTerrier linked an issue Oct 29, 2024 that may be closed by this pull request
5 tasks
@NoeTerrier NoeTerrier changed the title 76 subsonic page feat: 76 subsonic page Oct 30, 2024
Copy link
Contributor

@Thechi2000 Thechi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps there should be a new entry in the navigation bar to reference the page, or way to have a news card directly linking to it (and not to a news page). Also, there is no TabTitle (for the <title> and OG properties).

You also need to update the directus submodule version now that it has been merged.

@Thechi2000 Thechi2000 force-pushed the main branch 2 times, most recently from ee73f33 to 0f338a0 Compare October 30, 2024 23:06
@NoeTerrier
Copy link
Contributor Author

Perhaps there should be a new entry in the navigation bar to reference the page, or way to have a news card directly linking to it (and not to a news page). Also, there is no TabTitle (for the <title> and OG properties).

I wanted to have the page ready (filled with directus on production) to add it in the navbar

@NoeTerrier NoeTerrier requested a review from Thechi2000 November 1, 2024 18:31
@Thechi2000 Thechi2000 marked this pull request as ready for review November 1, 2024 22:14
@Thechi2000
Copy link
Contributor

Thechi2000 commented Nov 1, 2024

I wanted to have the page ready (filled with directus on production) to add it in the navbar

I'm not sure to understand. Do you want to add the navbar entry in a separate PR once the page is live ?

Btw my comment about TabTitle still needs resolving

@NoeTerrier
Copy link
Contributor Author

I'm not sure to understand. Do you want to add the navbar entry in a separate PR once the page is live ?

Yep, to let time for communication team to write and fill the page on directus before letting it visible on the main page.

Btw my comment about TabTitle still needs resolving

I don't understand, there is a TabTitle.

Thechi2000
Thechi2000 previously approved these changes Nov 3, 2024
Copy link
Contributor

@Thechi2000 Thechi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, there is a TabTitle.

Ah yes mb 🤦

@Thechi2000 Thechi2000 merged commit ff87463 into main Nov 3, 2024
3 checks passed
@Thechi2000 Thechi2000 deleted the 76-subsonic-page branch November 3, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Subsonic page
2 participants