-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 76 subsonic page #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps there should be a new entry in the navigation bar to reference the page, or way to have a news card directly linking to it (and not to a news page). Also, there is no TabTitle
(for the <title>
and OG properties).
You also need to update the directus submodule version now that it has been merged.
ee73f33
to
0f338a0
Compare
I wanted to have the page ready (filled with directus on production) to add it in the navbar |
I'm not sure to understand. Do you want to add the navbar entry in a separate PR once the page is live ? Btw my comment about TabTitle still needs resolving |
Yep, to let time for communication team to write and fill the page on directus before letting it visible on the main page.
I don't understand, there is a TabTitle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand, there is a TabTitle.
Ah yes mb 🤦
a1adfa2
to
2077450
Compare
2077450
to
82d7bb2
Compare
Close #76
Add subsonic page, with artists, plan, sponsors and description.