Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hosts name in activity cards #99

Merged
merged 3 commits into from
Feb 13, 2025
Merged

feat: add hosts name in activity cards #99

merged 3 commits into from
Feb 13, 2025

Conversation

NoeTerrier
Copy link
Contributor

Add hosts name to activities card. But there is a type error I don't know how to fix:

image

@NoeTerrier NoeTerrier added the help wanted Extra attention is needed label Feb 12, 2025
@NoeTerrier NoeTerrier self-assigned this Feb 12, 2025
@Thechi2000
Copy link
Contributor

I've pushed a fix. You had incorrectly cast the hosts field of the activity to ICBDSpeaker[], while there is actually one more inference level; ICBDActivity contains an array of relation items which themselves contain the ICBDSpeaker.

@Thechi2000 Thechi2000 force-pushed the ICBD-activities-hosts-names branch from c9fa1e0 to 41d263a Compare February 12, 2025 10:05
@NoeTerrier NoeTerrier marked this pull request as ready for review February 12, 2025 11:36
@NoeTerrier NoeTerrier merged commit 947c05f into main Feb 13, 2025
3 checks passed
@NoeTerrier NoeTerrier deleted the ICBD-activities-hosts-names branch February 13, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thechi2000 Thechi2000 Thechi2000 approved these changes

@SidonieBouthors SidonieBouthors Awaiting requested review from SidonieBouthors

Assignees

@NoeTerrier NoeTerrier

Labels
help wanted Extra attention is needed
Projects
CLIC website v2
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoeTerrier @Thechi2000