Feature/126 limit api importer #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New, better commits. Cleaner code. Please review. |
|
I think this branch should be updated with the latest from |
|
Rebased to current + pep8 fixes. |
| 'schedule': crontab(minute=0, hour=0, day_of_week='sun'), # Execute every sunday at midnight | ||
| }, | ||
| 'import-durham-data-incr': { | ||
| 'task': 'eatsmart.locations.durham.tasks.import_durham_data_incr', |
* Much faster imports from Durham County due to incremental nature of the data * Rewrote some of the API code for better clarity
|
New changes as discussed with @victor-rocha during the 6/3/2014 meeting. |
Refactoring some code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #126.
It should be only merged 24 hours after #127 is merged, as I would like for a complete import to happen first (that's how I tested it). In theory it should work on any database state... but that's untested.This is still not optimal - the inspections import has a for loop that causes a few hundreds calls to the Durham County API - most of them are unnecessary. Ideas?