-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus on CheckBox #3822
Focus on CheckBox #3822
Conversation
added the keycode that triggered the done event to the ActionEvent that is sent.
added clientProperty on textArea "backgroundColorOnFocus" to set backgroundColor of textArea on focus
As far as I can read the change you're requesting focus to the next component while processing an action in the currently editing component. This can have multiple edge cases and problems that impact everyone and also doesn't seem like the right thing. A change like this should be handled for the tab key only, not for everything. As a side note the indention for both lines modified is inconsistent with the rest of the code making it harder to read. |
Good morning, I modified my pull request now the component will only request focus if the TAB key was pressed |
Thanks. |
Good morning, i'm trying to implement focus on checkbox component with TAB on physical keyboard.
Debugging code i see that when i press TAB on my Device with physical keyboard from TextField to CheckBox it doesn't work.
It only works switching from a TextField to another, because of this code on Runnable onEditorAction in InPlaceEditView class (line 1233)
if (next != null && next instanceof TextArea) {
nextTextArea = (TextArea) next;
}
Adding fNext.requestFocus(); it works fine. is possible to publish this request or suggest me another way to do that?